Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planner): Fix aggregation in cluster mode #8309

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Oct 19, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

We derived the wrong data distribution of aggregation if there is more than one group key since we will actually use an internal column _group_by_key as the distribute key which cannot be recognized during planning for now.

This can be improved in the future.

Close #8290
Close #8292

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 19, 2022 at 8:19AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2022

This pull request's title is not fulfill the requirements. @leiysky please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@leiysky leiysky changed the title bugfix(planner): Fix aggregation in cluster mode fix(planner): Fix aggregation in cluster mode Oct 19, 2022
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Oct 19, 2022
@BohuTANG BohuTANG merged commit 2c4f290 into databendlabs:main Oct 19, 2022
@leiysky leiysky deleted the fix-distributed-aggregation branch October 19, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: wrong result after having count(1) bug: groupby result not merged in cluster mode
3 participants