Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename to data operator to make space for cache #8314

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 19, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #6803

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 19, 2022 at 11:44AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 19, 2022
@BohuTANG
Copy link
Member

Why change the storage name to persist? persist is not easy to understand at a glance.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 19, 2022

Why change the storage name to persist? persist is not easy to understand at a glance.

persist, cache, and temporary will share the same storage config struct. Change StorageOperator to PersistOperator can make it easier to distinguish with StorageConfig.

After this change, all StorageXxx will apply for all operator types.

Better names than persist are welcome.

@BohuTANG
Copy link
Member

How about DataOperator?

@Xuanwo Xuanwo marked this pull request as draft October 19, 2022 10:53
mergify bot and others added 2 commits October 19, 2022 11:07
@Xuanwo Xuanwo changed the title refactor: Rename to persist operator to make space for cache refactor: Rename to data operator to make space for cache Oct 19, 2022
@Xuanwo Xuanwo marked this pull request as ready for review October 19, 2022 11:44
@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 19, 2022

How about DataOperator?

Updated.

@mergify mergify bot merged commit 263dd3f into databendlabs:main Oct 19, 2022
@Xuanwo Xuanwo deleted the refactor-storage-operator branch October 19, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants