Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query/service): Move query/service/utils to sub mods #8360

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Oct 20, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • src/query/service/src/utils/download.rs --> src/query/service/src/servers/http/v1/download.rs
  • src/query/service/src/interpreters/stream/processor_executor_stream.rs --> src/query/service/src/stream/processor_executor_stream.rs
  • src/query/service/src/utils/storage_table_read_wrap.rs --> src/query/service/src/stream/table_read_block_stream.rs

Fixes #issue

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 20, 2022 at 9:52AM (UTC)

@BohuTANG BohuTANG marked this pull request as ready for review October 20, 2022 09:59
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2022

This pull request's title is not fulfill the requirements. @BohuTANG please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@BohuTANG BohuTANG changed the title reafactor(query/service): Move query/service/utils to sub mods refactor(query/service): Move query/service/utils to sub mods Oct 20, 2022
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 20, 2022
@BohuTANG BohuTANG merged commit 0184427 into databendlabs:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant