Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta/management): allow to join a cluster if a meta node has no log #8384

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat(meta/management): allow to join a cluster if a meta node has no log

Databend-meta should allow to join a cluster if it has not yet joined a
cluster, i.e., its raft-log is empty.

Currently, it's only allowed only when the node is uninitialized. Thus
the problem is if the first attempt to join fails, a node can never be
joined.

Changelog

Related Issues

Databend-meta should allow to join a cluster if it has not yet joined a
cluster, i.e., its raft-log is empty.

Currently, it's only allowed only when the node is uninitialized. Thus
the problem is if the first attempt to join fails, a node can never be
joined.

- Fix: databendlabs#8383
@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Oct 21, 2022 at 5:48AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Oct 21, 2022
@drmingdrmer drmingdrmer marked this pull request as ready for review October 21, 2022 05:49
@drmingdrmer drmingdrmer merged commit 429db10 into databendlabs:main Oct 21, 2022
@drmingdrmer drmingdrmer deleted the 45-join branch October 21, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow joining if a node has not yet joined a cluster.
1 participant