-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support copy from xml. #8404
Conversation
Signed-off-by: Elias.Yao <siran0611@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Signed-off-by: Elias.Yao <siran0611@gmail.com> # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
If proto files change, add a line to increase the version and describe what changes are introduced: And add test to load this version of the message, reference: |
Signed-off-by: Elias.Yao <siran0611@gmail.com>
src/query/pipeline/sources/src/processors/sources/input_formats/impls/input_format_xml.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Elias.Yao <siran0611@gmail.com>
|
@mergify update |
✅ Branch has been successfully updated |
Signed-off-by: Elias.Yao <siran0611@gmail.com>
src/query/pipeline/sources/src/processors/sources/input_formats/impls/input_format_xml.rs
Outdated
Show resolved
Hide resolved
src/query/pipeline/sources/src/processors/sources/input_formats/impls/input_format_xml.rs
Outdated
Show resolved
Hide resolved
src/query/pipeline/sources/src/processors/sources/input_formats/impls/input_format_xml.rs
Outdated
Show resolved
Hide resolved
Please add a stateful test case to make sure we can load data from XML correctly~ |
by the way, do you know any real life cases of loading from XML? |
We can test against https://www.treasurydirect.gov/xml/ |
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
…_buffer_size Signed-off-by: Elias.Yao <siran0611@gmail.com>
ontime.xml can be removed now. |
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
others LGTM |
Signed-off-by: Elias.yao <siran0611@gmail.com>
Signed-off-by: Elias.Yao <siran0611@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your persistence and contribution.
cc @soyeric128, we supports copy from xml format now! |
OK. Nice to see COPY INTO grows stronger, BTW. |
Some quick questions about the file formats:
|
Y.
Y. |
Does a single data file have a size limit when working with the streaming load API or COPY INTO command? |
No such limit so far. It's better to start a new discussion at https://github.com/datafuselabs/databend/discussions so that we are not disturbing subscribers of this PR 💌 |
Signed-off-by: Elias.Yao siran0611@gmail.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
my implementation references mysql, and test complele stream load and copy stage
format1:
format2:
format3:
finally, line 119 in input_context.rs, would it be better to have then as arguments to the input_context.