refactor(query): remove legacy crate codes

Cargo.toml

@@ -35,15 +35,12 @@ members = [
     "src/query/formats",
     "src/query/functions",
     "src/query/functions-v2",
-    "src/query/legacy-parser",
     "src/query/management",
     "src/query/planner",
     "src/query/pipeline/core",
     "src/query/pipeline/sinks",
     "src/query/pipeline/sources",
     "src/query/pipeline/transforms",
-    "src/query/legacy-expression",
-    "src/query/legacy-planners",
     "src/query/settings",
     "src/query/sql",
     "src/query/storages/cache",

src/query/README.md

@@ -12,7 +12,6 @@ Databend Query is a Distributed Query Engine at scale.
 - [`formats`](./formats/), the serialization and deserialization of data in various formats to the outside.
 - [`functions`](./functions/), scalar functions and aggregate functions, etc., will be gradually migrated to `functions-v2`.
 - [`functions-v2`](./functions-v2/), scalar functions and aggregate functions, etc., based on `expression`.
-- [`legacy-parser`](./legacy-parser/), the old parser, which will be replaced by ast, built with sqlparser-rs.
 - [`menagement`](./menagement/) for clusters, quotas, etc.
 - [`pipeline`](./pipeline/) implements the scheduling framework for physical operators.
 - [`planners`](./planners/) builds an execution plan from the user's SQL statement and represents the query with different types of relational operators.

src/query/catalog/Cargo.toml

@@ -16,11 +16,10 @@ common-datavalues = { path = "../datavalues" }
 common-exception = { path = "../../common/exception" }
 common-functions = { path = "../functions" }
 common-io = { path = "../../common/io" }
-common-legacy-expression = { path = "../legacy-expression" }
-common-legacy-planners = { path = "../legacy-planners" }
 common-meta-app = { path = "../../meta/app" }
 common-meta-types = { path = "../../meta/types" }
 common-pipeline-core = { path = "../pipeline/core" }
+common-planner = { path = "../planner" }
 common-settings = { path = "../settings" }
 common-storage = { path = "../../common/storage" }
 

src/query/catalog/src/table.rs

@@ -24,15 +24,15 @@ use common_datavalues::DataSchemaRef;
 use common_datavalues::DataValue;
 use common_exception::ErrorCode;
 use common_exception::Result;
-use common_legacy_expression::LegacyExpression;
-use common_legacy_planners::DeletePlan;
-use common_legacy_planners::Extras;
-use common_legacy_planners::Partitions;
-use common_legacy_planners::ReadDataSourcePlan;
-use common_legacy_planners::Statistics;
 use common_meta_app::schema::TableInfo;
 use common_meta_types::MetaId;
 use common_pipeline_core::Pipeline;
+use common_planner::extras::Extras;
+use common_planner::extras::Statistics;
+use common_planner::plans::DeletePlan;
+use common_planner::Expression;
+use common_planner::Partitions;
+use common_planner::ReadDataSourcePlan;
 use common_storage::StorageMetrics;
 
 use crate::table::column_stats_provider_impls::DummyColumnStatisticsProvider;
@@ -90,7 +90,7 @@ pub trait Table: Sync + Send {
         false
     }
 
-    fn cluster_keys(&self) -> Vec<LegacyExpression> {
+    fn cluster_keys(&self) -> Vec<Expression> {
         vec![]
     }
 
@@ -136,7 +136,7 @@ pub trait Table: Sync + Send {
         )))
     }
 
-    fn table_args(&self) -> Option<Vec<LegacyExpression>> {
+    fn table_args(&self) -> Option<Vec<DataValue>> {
         None
     }
 

src/query/catalog/src/table_args.rs

@@ -12,6 +12,6 @@
 //  See the License for the specific language governing permissions and
 //  limitations under the License.
 
-use common_legacy_expression::LegacyExpression;
+use common_datavalues::DataValue;
 
-pub type TableArgs = Option<Vec<LegacyExpression>>;
+pub type TableArgs = Option<Vec<DataValue>>;

src/query/catalog/src/table_context.rs

@@ -24,11 +24,11 @@ use common_datablocks::DataBlock;
 use common_exception::Result;
 use common_functions::scalars::FunctionContext;
 use common_io::prelude::FormatSettings;
-use common_legacy_planners::PartInfoPtr;
-use common_legacy_planners::Partitions;
-use common_legacy_planners::ReadDataSourcePlan;
 use common_meta_types::RoleInfo;
 use common_meta_types::UserInfo;
+use common_planner::PartInfoPtr;
+use common_planner::Partitions;
+use common_planner::ReadDataSourcePlan;
 use common_settings::Settings;
 use common_storage::DataOperator;
 use common_storage::StorageMetrics;

src/query/datablocks/src/data_block.rs

@@ -195,11 +195,10 @@ impl DataBlock {
     }
 
     #[inline]
-    pub fn remove_column(self, name: &str) -> Result<Self> {
+    pub fn remove_column_index(self, idx: usize) -> Result<Self> {
         let mut columns = self.columns.clone();
         let mut fields = self.schema().fields().clone();
 
-        let idx = self.schema.index_of(name)?;
         columns.remove(idx);
         fields.remove(idx);
         let new_schema = Arc::new(DataSchema::new(fields));
@@ -220,6 +219,12 @@ impl DataBlock {
         })
     }
 
+    #[inline]
+    pub fn remove_column(self, name: &str) -> Result<Self> {
+        let idx = self.schema.index_of(name)?;
+        self.remove_column_index(idx)
+    }
+
     #[inline]
     pub fn resort(self, schema: DataSchemaRef) -> Result<Self> {
         let mut columns = Vec::with_capacity(self.num_columns());

src/query/datavalues/src/columns/primitive/primitive.rs

@@ -87,10 +87,17 @@ impl<T: PrimitiveType> PrimitiveColumn<T> {
                 // for all the timestamp column we will cast to int64 with microsecond precision
                 ArrowDataType::Timestamp(x, _) => {
                     let p = convert_precision_to_micros(x);
+
+                    if p == (1, 1) {
+                        let array = array.as_any().downcast_ref::<PrimitiveArray<T>>().unwrap();
+                        return Self::new(array.clone());
+                    }
+
                     let array = array
                         .as_any()
                         .downcast_ref::<PrimitiveArray<i64>>()
                         .expect("primitive cast should be ok");
+
                     let array = unary(array, |x| x * p.0 / p.1, expected_arrow);
 
                     Self::from_arrow_array(&array)
@@ -104,11 +111,16 @@ impl<T: PrimitiveType> PrimitiveColumn<T> {
                         .expect("primitive cast should be ok");
 
                     let array = unary(array, |x| x as i64 * p.0 / p.1, expected_arrow);
-
                     Self::from_arrow_array(&array)
                 }
                 ArrowDataType::Time64(x) => {
                     let p = convert_precision_to_micros(x);
+
+                    if p == (1, 1) {
+                        let array = array.as_any().downcast_ref::<PrimitiveArray<T>>().unwrap();
+                        return Self::new(array.clone());
+                    }
+
                     let array = array
                         .as_any()
                         .downcast_ref::<PrimitiveArray<i64>>()