feat(meta): auto-clean expired keys #8539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-feature
drmingdrmer
force-pushed
the
80-expire
branch
from
893df66 to
32df67d
Compare
- Clean upto 32 expired keys before applying a raft-log.
- When modifying(insert/update/delete) a kv record, it emits at most two event:
- If the existent key expired, emit a `delete` event, because a
expired key is seen and removed.
- Then the event of the update follows.
- Fix: databendlabs#8489
- Fix: databendlabs#8490
- Fix: databendlabs#8540
drmingdrmer
force-pushed
the
80-expire
branch
from
32df67d to
fd0cb56
Compare
Xuanwo
reviewed
Oct 31, 2022
Xuanwo
approved these changes
Oct 31, 2022
BohuTANG
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
feat(meta): auto-clean expired keys
Clean up to 32 expired keys before applying a raft-log.
When modifying(insert/update/delete) a kv record, it emits at most two events:
deleteevent because anexpired key is seen and removed.
Fix: Update index
Expireeverywhere a key is updated withupsert():KVApi::uspert()andKVApi::transaction(). #8489Fix: meta: Cleaning up keys should not affect the state in other key spaces #8490
Fix: Feed expired key deletion events to subscriber, then finally deliver to a
watchclient. #8540Changelog
Related Issues