-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file format): unify format settings/options. #8566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request's title is not fulfill the requirements. @youngsofun please update it 🙏. Valid format:
Valid types:
|
youngsofun
changed the title
Feat: unify format settings/options.
feat(file format): unify format settings/options.
Nov 1, 2022
youngsofun
force-pushed
the
fix
branch
2 times, most recently
from
November 1, 2022 12:18
d3495dc
to
0f5e190
Compare
): not use ValuesOutputFormat for now.
error message: Cast error happens in casting from Array(Nullable(UInt8)) to Array(Nullable(Int64))
sundy-li
approved these changes
Nov 2, 2022
PsiACE
approved these changes
Nov 2, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
same options used for:
todo
""
for escape by default in CSV outputlet options = fmt.f1(settings)
;let format_setting = fmt.f2(options)
nan
instead ofNaN
used NestedFormatSettings in input formats
)Fixes #8491