refactor(meta): return InvalidReply if fail to decode a message #8568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During upgrading, different version of databend-query/meta run in a same cluster. If a message that can not be decoded received, return an `InvalidReply` error instead of just panicking the program. Returning such an error might make the cluster unable to operate while upgrading, but data durability and consistency won't be compromised.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
everpcpc
approved these changes
Nov 1, 2022
Xuanwo
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
refactor(meta): return InvalidReply if fail to decode a message
During upgrading, different version of databend-query/meta run in a same
cluster. If a message that can not be decoded received, return an
InvalidReplyerror instead of just panicking the program.Returning such an error might make the cluster unable to operate while
upgrading, but data durability and consistency won't be compromised.
Changelog
Related Issues