Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(function): cast timestamp to variant string instead of variant int #8580

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Nov 1, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  ast            : CAST(to_timestamp(1000000) AS VARIANT)
  raw expr       : CAST(to_timestamp(1000000_u32) AS Variant)
  checked expr   : CAST(to_timestamp<Int64>(CAST(1000000_u32 AS Int64)) AS Variant)
- optimized expr : 0x200000002000000940000000e8d4a51000
+ optimized expr : 0x200000001000001a313937302d30312d31322031333a34363a34302e303030303030
  output type    : Variant
  output domain  : Undefined
- output         : 1000000000000
+ output         : "1970-01-12 13:46:40.000000"

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 1, 2022 at 11:20AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 1, 2022
@RinChanNOWWW
Copy link
Contributor

Why change &Tz to Tz?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 1, 2022

Why change &Tz to Tz?

Tz is Copy?

@mergify mergify bot merged commit faeeff7 into databendlabs:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants