refactor: compact segments #8590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mergify
bot
added
the
pr-refactor
dantengsky
force-pushed
the
refactor-segment-compact-new
branch
from
beffc99 to
c0ddfbc
Compare
zhyass
reviewed
Nov 7, 2022
src/query/storages/fuse/fuse/src/operations/mutation/compact_mutator/segment_compact_mutator.rs
Show resolved
Hide resolved
BohuTANG
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
new implementation of
compact segmentswhich strictly preserves the order of ingestion
to avoid the
ripple effectswhich may lead to a large number of consecutive compacted segments being split and merged again and again, for even a single fragmented segment, during compaction, segments of size [threshold, 2 * threshold) are allowed to be generated.the "semantic" of the statement optimize table t compact segment
limit nadjusted to the max number of fragmented segments to be compactednote that at the end of compaction, if there are fragmented segments left (the combined size of them should be lesser than the threshold), they will be compacted into a segment, those segments are not counted for the
limit.Fixes #issue