Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storages): move prelude table engines from preludes to storages #8613

Merged
merged 8 commits into from
Nov 3, 2022
Merged

refactor(storages): move prelude table engines from preludes to storages #8613

merged 8 commits into from
Nov 3, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Nov 3, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • move out view table to storages/view
  • move out information_schema table to storages/information-schema
  • move out result table to storages/fuse-result
  • move out memory table to storages/memory
  • move out null table to storages/null
  • move out random table to storages/random
  • move out stage table to storages/stage

Fixes #issue

@vercel
Copy link

vercel bot commented Nov 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 3, 2022 at 5:19AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 3, 2022
@BohuTANG BohuTANG changed the title refactor(storages): move table engines from preludes to storages refactor(storages): move table engines from preludes to storages [Patch-1] Nov 3, 2022
@BohuTANG
Copy link
Member Author

BohuTANG commented Nov 3, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2022

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@BohuTANG
Copy link
Member Author

BohuTANG commented Nov 3, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2022

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG force-pushed the dev-storage-refactor2 branch from c99dd8a to 572e1ea Compare November 3, 2022 04:37
@BohuTANG BohuTANG changed the title refactor(storages): move table engines from preludes to storages [Patch-1] refactor(storages): move prelude table engines from preludes to storages Nov 3, 2022
@BohuTANG BohuTANG marked this pull request as ready for review November 3, 2022 05:20
@BohuTANG BohuTANG merged commit cb2359f into databendlabs:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BohuTANG @Xuanwo