Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storages): move fuse&hive to single folder #8621

Merged
merged 5 commits into from
Nov 3, 2022
Merged

refactor(storages): move fuse&hive to single folder #8621

merged 5 commits into from
Nov 3, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Nov 3, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • fuse&fuse-meta to fuse/
  • hive&hive-meta-store to hive/

Fixes #issue

@vercel
Copy link

vercel bot commented Nov 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 3, 2022 at 7:57AM (UTC)

@BohuTANG BohuTANG mentioned this pull request Nov 3, 2022
Closed
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 3, 2022
@BohuTANG
Copy link
Member Author

BohuTANG commented Nov 3, 2022

@sandflee @dantengsky @zhyass
This PR adjusts the directory structure to make it more organized, please comments let me know if this PR breaks your WIP PR.

@BohuTANG BohuTANG marked this pull request as ready for review November 3, 2022 07:28
@BohuTANG BohuTANG requested review from dantengsky, zhyass and FANNG1 and removed request for dantengsky November 3, 2022 07:28
dantengsky
dantengsky approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FANNG1
Copy link

FANNG1 commented Nov 3, 2022

BTW, hive use some components from fuse, like range filter and 'cache' etc. maybe sometimes we could do another refactor to seperate the common components from fuse.

@BohuTANG BohuTANG merged commit 9feff7a into databendlabs:main Nov 3, 2022
@BohuTANG BohuTANG mentioned this pull request Nov 3, 2022
Closed
@BohuTANG
Copy link
Member Author

BohuTANG commented Nov 3, 2022 •
edited
Loading

@sandflee

cache and index are the single crates under the storages.
image

I think you are mean common-storages-fuse-meta = { path = "../../fuse/fuse-meta" }, which is used by hive/cargo.toml

https://github.com/datafuselabs/databend/blob/9feff7a1449095923a101695aaa4928625377684/src/query/storages/hive/hive/Cargo.toml#L29

@FANNG1
Copy link

FANNG1 commented Nov 3, 2022 •
edited
Loading

cache and index are the single crates under the storages.

have not noticed there are moved from fuse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@FANNG1 FANNG1 FANNG1 approved these changes

@zhyass zhyass Awaiting requested review from zhyass

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BohuTANG @FANNG1 @Xuanwo @dantengsky