-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy files order by last modified time asc #8628
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
d87f1ff
to
d447fc5
Compare
Why we need this change? After stream copy implemented, we can't do sort like this anymore. |
If we have many files need to copy, let the oldest files fisrt, we can keep the insert order same as the file modified order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't make sense to me. But worth a try.
It feels possible to add a switch for it if necessary. |
We can't sort the files if there are 10W files, we will copy them in stream which will in the order returned by list (in the near future). |
So I suggest leaving it up to the user to decide whether to use this change set order_by_last_modified_time = 1 |
|
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Copy files in asc order of file last modification time.
Closes #issue