fix(meta): emit kv change events after committing a transaction #8674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
drmingdrmer
force-pushed
the
52-events
branch
2 times, most recently
from
be2287d to
e633d60
Compare
Otherwise, pushing any events before a transaction being committed potentially results in duplicated messages. Replace `NotifyKVEvent` with `Change`, which is more generic to describe an event.
drmingdrmer
force-pushed
the
52-events
branch
from
e633d60 to
9348d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
fix(meta): emit kv change events after committing a transaction
Otherwise, pushing any events before a transaction being committed
potentially results in duplicated messages.
Replace
NotifyKVEventwithChange, which is more generic to describe an event.chore(meta): nothing changed
Changelog
Related Issues