Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts caused by "preserve_order" feature of serde_json #55

Closed
CookiePieWw opened this issue Aug 29, 2024 · 0 comments · Fixed by #56
Closed

Conflicts caused by "preserve_order" feature of serde_json #55

CookiePieWw opened this issue Aug 29, 2024 · 0 comments · Fixed by #56

Comments

@CookiePieWw
Copy link
Contributor

Hi! I'm trying to introduce jsonb into a project (see GreptimeTeam/greptimedb#4619), but the project relies on the non-preserve-order nature of serde_json, which conflicts with jsonb. I've noticed that the feature is used to preserve the order of json objects in conversions, while the order of objects is not guaranteed according to RFC. Are there other things relying on it?

I wonder if it's proper to put a trigger on the feature as what serde_json does for better compatibility. If so, I'd like to submit a patch for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant