Experiment the effect of removing perCapita stop words #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejennifer
reviewed
Jun 28, 2024
pradh
reviewed
Jul 8, 2024
| "Count_CriminalActivities_LarcenyTheft", | ||
| "Count_CriminalActivities_Robbery", |
| @@ -31,7 +31,6 @@ | |||
| } | |||
| ], | |||
| "denom": "Count_Person", | |||
| "startWithDenom": true, | |||
There was a problem hiding this comment.
I don't understand why we are losing startWithDenom?
| # WARNING: These will conflate with Correlation | ||
| "vs", | ||
| "versus", | ||
| QUERY_CLASSIFICATION_HEURISTICS: Dict[str, Union[List[str], Dict[str, List[str]]]] = { |
There was a problem hiding this comment.
Is there anything actually changing in this dict, or are these just formatting diffs?
| "title": "Median Family Household Income (${yDate}) Vs. Diabetes (${xDate}) in Counties of United States", | ||
| "type": "SCATTER" | ||
| } | ||
| ] |
shifucun
commented
Jul 8, 2024
Comment on lines
+308
to
+309
| "\brate\b(?!\s*(birth|change|death|exchange|fertility|literacy|mortality|participation|unemployment|withdrawal)\s+rate)", | ||
| "rates" |
There was a problem hiding this comment.
this is the actual change
|
|
||
| # We do not want to strip words from events / superlatives / temporal | ||
| # since we want those to match SVs too! | ||
| HEURISTIC_TYPES_IN_VARIABLES = frozenset( | ||
| ["Event", "Superlative", "Temporal", "PerCapita"]) | ||
| HEURISTIC_TYPES_IN_VARIABLES = frozenset(["Event", "Superlative", "Temporal"]) |
There was a problem hiding this comment.
this is the actual change
|
svindex differ result: https://storage.mtls.cloud.google.com/datcom-embedding-diffs/chejennifer_base_uae_mem_2024_07_09_15_03_08.html base does not strip per capita stop words |
chejennifer
added a commit
that referenced
this pull request
Jul 12, 2024
same change as #4415 but rebased off a clean master svindex diff: https://storage.mtls.cloud.google.com/datcom-embedding-diffs/chejennifer_base_uae_mem_2024_07_09_21_55_14.html base does not remove per capita stop words test removes per capita stop words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.