Switch from "fork" to "spawn" for multiprocessing in tests #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still makes Web Driver unhappy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some kind of mysterious cloud build platform change broke "fork" start method for python
multiprocessing. The "spawn" start method is apparently a safer alternative, since it doesn't inherit parent state into child (sharing state can cause deadlocks or mess up behavior, perhaps like we see now) -- doc.However, "spawn" is finicky about pickling of methods and objects that get passed to the
run()method.So, this change does three things to switch over to "spawn" mode:
multiprocessing.Processcall we make to start NL server in a way that makes spawn happyflask_testing) in a way that makes spawn unhappy. So, stop using that (generally unmaintained) library, and instead start web server in our code.