Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command (dataform run) --tags flag does not accept a list of tags #1200

Open
danieldeleo opened this issue Mar 10, 2021 · 4 comments · Fixed by #1695
Open

CLI command (dataform run) --tags flag does not accept a list of tags #1200

danieldeleo opened this issue Mar 10, 2021 · 4 comments · Fixed by #1695

Comments

@danieldeleo
Copy link

The CLI help text describes --flags as: "A list of tags to filter the actions to run. [array]"

Currently the only method that works for supplying multiple tags to the --tags flag is to specify the option multiple times:
--tags value1 --tags value2

The following methods do not currently work for supplying multiple flags:
--tags value1 value2
--tags value1,value2

@danieldeleo
Copy link
Author

This behavior also applies to the --actions flag

The actions flag additionally specifies, Can include '*' wildcards. but this feature does not seem to be working.

@andres-lowrie
Copy link
Contributor

passing in a flag multiple time is pretty common for cli tools (like for example grep -e )

calling this out so that the multiple option isn't removed but instead --tags val1,val2 is added to the parser; ie: both ways would work

@federicojasson
Copy link

@Ekrekr Hi 👋

Question: was there any technical reason for not adding the same logic for the --actions flag in #1695?
Currently, --actions action1,action2 doesn't split by comma.

Thanks!

@Ekrekr
Copy link
Contributor

Ekrekr commented May 23, 2024

No, that sounds reasonable - reopening.

@Ekrekr Ekrekr reopened this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants