-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post json instead of sql in /v1/statement/ #2604
Comments
trino v2 plan to use json too https://github.com/trinodb/trino/wiki/Trino-v2-client-protocol |
the trino v2 protocol is much better IMO 🤔 |
I prefer json schema. post json data provided advanced security guarantees and would be good to integrate needed fields without missing, on contrary, add a lot of queries in get would be quite messy |
@ZhiHanZ which do you prefer
|
case 3 looks make sense, |
/assignme |
Summary
the first version of http handler, post raw sql statement to /v1/statement/.
I think it is better to post json instead to carry more context info.
reasons
how
since /v1/statement/ is used in cli and playground. we need to discuss the way to do it.
possible reason to reserve the raw_sql api:
sorry for not thinking it clearly to begin with.
@flaneur2020 @ZhiHanZ
related issue
#2241
The text was updated successfully, but these errors were encountered: