Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix rust toolchain not fixed correctly #3882

Merged
merged 6 commits into from
Jan 18, 2022
Merged

ci: Fix rust toolchain not fixed correctly #3882

merged 6 commits into from
Jan 18, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 18, 2022 •
edited
Loading

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix rust toolchain in CI not fixed as specified in rust-toolchain.toml.

Changelog

  • Bug Fix

Test Plan

Unit Tests

Stateless Tests

@Xuanwo
ci: Fix rust toolchain not fixed correctly
36c392b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner January 18, 2022 02:04
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-bugfix this PR patches a bug in codebase label Jan 18, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 18, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2AuHuoK1GBRcSjgam7T2hCAoQcdV
✅ Preview: Canceled

[Deployment for 3a87672 canceled]

@Xuanwo Xuanwo marked this pull request as draft January 18, 2022 02:04
@Xuanwo
Use rust-toolchain instead
6feb915 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Revert "Use rust-toolchain instead"
81facca 
This reverts commit 6feb915.
@Xuanwo
Use forked version
ef40f01 
Signed-off-by: Xuanwo <github@xuanwo.io>
@sundy-li sundy-li mentioned this pull request Jan 18, 2022
Closed
@Xuanwo
Apply to all actions
832f208 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review January 18, 2022 03:16
@Xuanwo Xuanwo requested review from PsiACE and ZhiHanZ January 18, 2022 03:19
@Xuanwo
Use native rustup instead
3a87672 
Signed-off-by: Xuanwo <github@xuanwo.io>
PsiACE
PsiACE approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the ci is passed, we can merge it.

Based on this practice, we can simplify/remove the logic in dev_steup.sh for the rust toolchain.

@BohuTANG BohuTANG merged commit a479e82 into databendlabs:main Jan 18, 2022
@Xuanwo Xuanwo deleted the ci_fix branch January 24, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsiACE PsiACE PsiACE approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@ZhiHanZ ZhiHanZ Awaiting requested review from ZhiHanZ

Assignees
No one assigned
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @databend-bot @PsiACE @BohuTANG