-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-938: Datafuse CLI #950
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
========================================
- Coverage 71% 71% -1%
========================================
Files 456 474 +18
Lines 27212 28751 +1539
========================================
+ Hits 19586 20682 +1096
- Misses 7626 8069 +443
Continue to review full report at Codecov.
|
#[derive(StructOpt, Debug)] | ||
pub struct VersionCommand {} | ||
|
||
impl VersionCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should also support remote tag for version, i.e:
fusecli version --remote=true // show local client version and remote cluster version
fusecli version --remotve=false // only show local client version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
This will be started after #991 |
Hello @BohuTANG, 🎉 Thank you for opening the pull request! 🎉 |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Changelog
Related Issues
Fixes #938
Test Plan
Unit Tests
Stateless Tests