Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionContextImpl.findObject should have extra argument for case where we want to check inheritance below a particular class #143

Open
andyjefferson opened this issue Oct 9, 2016 · 2 comments

Comments

@andyjefferson
Copy link
Member

Being able to check the inheritance level of an "id" is essential, but on occasion we know that an object is of a particular level or subclass (e.g relation loading). We should be able to pass in the class. Perhaps this could even reuse the fourth argument, but would need to update calls to use it in that way, and fix javadocs to be clear about the usages.

@andyjefferson andyjefferson added this to the 5.1.0.m1 milestone Oct 9, 2016
@andyjefferson
Copy link
Member Author

While doing this, we should consider adding a method ExecutionContext.findObjects for multiple ids of the same candidate.

@andyjefferson andyjefferson modified the milestones: 5.1.0.m1, 5.1.0.m2 Mar 15, 2017
@andyjefferson andyjefferson modified the milestones: 5.1.0.m2, 5.1.0.m3 Apr 26, 2017
@andyjefferson andyjefferson modified the milestones: 5.1.0.m3, 5.1.0.m4 May 31, 2017
@andyjefferson andyjefferson modified the milestones: 5.1.0.release, 5.1.0.m4 Jul 4, 2017
@andyjefferson andyjefferson removed this from the 5.1.0.m5 milestone Jul 12, 2017
@andyjefferson
Copy link
Member Author

The latter item "ExecutionContext.findObjects" was added to v5.1.0.m5.
The original item needs a test case defining so that we have something to work against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant