From 2877586ddef5a084fa2a7a8d4e708bd2c1aba59b Mon Sep 17 00:00:00 2001
From: Sam Morley <admin@inakleinbottle.com>
Date: Tue, 24 Oct 2023 10:04:06 +0100
Subject: [PATCH] Fix bits to bytes

---
 scalars/src/scalar_implementations/bfloat16/b_float_16_type.cpp | 2 +-
 scalars/src/scalar_implementations/rational/RationalType.cpp    | 2 +-
 .../rational_poly/rational_poly_scalar_type.h                   | 2 +-
 scalars/src/standard_scalar_type.h                              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/scalars/src/scalar_implementations/bfloat16/b_float_16_type.cpp b/scalars/src/scalar_implementations/bfloat16/b_float_16_type.cpp
index 59858aedf..813ddd806 100644
--- a/scalars/src/scalar_implementations/bfloat16/b_float_16_type.cpp
+++ b/scalars/src/scalar_implementations/bfloat16/b_float_16_type.cpp
@@ -43,6 +43,6 @@ BFloat16Type::BFloat16Type()
     : StandardScalarType<bfloat16>(
             string("BFloat16"), string("bf16"), sizeof(bfloat16),
             alignof(bfloat16),
-            {ScalarTypeCode::BFloat, sizeof(bfloat16) * CHAR_BIT, 1U},
+            {ScalarTypeCode::BFloat, sizeof(bfloat16), 1U},
             {devices::DeviceType::CPU, 0})
 {}
diff --git a/scalars/src/scalar_implementations/rational/RationalType.cpp b/scalars/src/scalar_implementations/rational/RationalType.cpp
index de9f0c9c7..b905c786c 100644
--- a/scalars/src/scalar_implementations/rational/RationalType.cpp
+++ b/scalars/src/scalar_implementations/rational/RationalType.cpp
@@ -72,7 +72,7 @@ RationalType::RationalType()
             sizeof(rational_scalar_type),
             alignof(rational_scalar_type),
             {
-                                    ScalarTypeCode::OpaqueHandle,
+                                    ScalarTypeCode::ArbitraryPrecisionRational,
                                     0, 0,
                                     },
             {       devices::DeviceType::CPU, 0   }
diff --git a/scalars/src/scalar_implementations/rational_poly/rational_poly_scalar_type.h b/scalars/src/scalar_implementations/rational_poly/rational_poly_scalar_type.h
index 0fb206192..d0018f3eb 100644
--- a/scalars/src/scalar_implementations/rational_poly/rational_poly_scalar_type.h
+++ b/scalars/src/scalar_implementations/rational_poly/rational_poly_scalar_type.h
@@ -58,7 +58,7 @@ class RationalPolyScalarType
                 string("RationalPoly"),
                 sizeof(rational_poly_scalar),
                 alignof(rational_poly_scalar),
-                {ScalarTypeCode::OpaqueHandle, 0, 0},
+                {ScalarTypeCode::APRationalPolynomial, 0, 0},
                 {devices::DeviceType::CPU, 0},
     }, devices::get_cpu_device())
     {}
diff --git a/scalars/src/standard_scalar_type.h b/scalars/src/standard_scalar_type.h
index 55b4dd618..63e1d4c2f 100644
--- a/scalars/src/standard_scalar_type.h
+++ b/scalars/src/standard_scalar_type.h
@@ -92,7 +92,7 @@ class StandardScalarType : public impl_helpers::ScalarTypeHelper<ScalarImpl>
                 std::move(id),
                 sizeof(ScalarImpl),
                 alignof(ScalarImpl),
-                {ScalarTypeCode::Float, sizeof_bits<ScalarImpl>(), 1U},
+                {ScalarTypeCode::Float, sizeof(ScalarImpl), 1U},
                 {devices::DeviceType::CPU, 0}
     }, devices::get_cpu_device())
     {}