Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script creates multiple small boxes with close symbol on it on the top left corner side. #1

Closed
WhoMI7 opened this issue Jan 3, 2022 · 5 comments

Comments

@WhoMI7
Copy link

WhoMI7 commented Jan 3, 2022

image

Annoying popups.

@datasone
Copy link
Owner

The popup is actually a helper window for activating SMTC (Windows requires a visible window to activate it, so a hidden or zero-sized window won't work). I'm finding a way to hide it out of screen, but haven't got a stable approach to achieve that.

@NaiveInvestigator
Copy link

NaiveInvestigator commented Feb 27, 2022

Sorry if it sounds too obvious but can't we somehow use the mpv window to activate SMTC instead of using a helper window? or maybe hide the mpv window and instead stream its contents, input output and all to the helper window so it looks like we are using mpv not the helper window. Sorry it sounds unreasonable.

@datasone
Copy link
Owner

datasone commented Mar 4, 2022

@NaiveInvestigator Well, Windows seems to limit this a lot (the window must be created by the same process, and it must be visible, i.e. no 0x0 or hidden). But after a little looking into the docs, it seems there are some other methods to create SMTC without the need of a window, so I'm trying that to solve the issue.

@NaiveInvestigator
Copy link

NaiveInvestigator commented Mar 4, 2022

THAT IS DOPE! Hope that works too. Btw i think we should also add a way to autostart the executable automatically so it will be easier for ppl to use it. I put up a pull request for as a suggestion on too, please do check it out.

It is in no way complete but I think it does the work admirably.

Edit: looking forward to the update!!

Edit -2 : I forgot to mention u but the script doesn't seem to work when i use mpv to stream youtube. Not that is a big issue but it gives an error Lua error: [string "D:/Program Files (x86)/mpv/portable_config/sc..."]:110: attempt to perform arithmetic on global 'dir' (a string value). Just thought to let u know about that.

@datasone
Copy link
Owner

datasone commented Mar 8, 2022

The legacy window-creating method has been changed to using MediaPlayer API, so the windows won't appear. A new release 0.0.3 has been created.

@NaiveInvestigator For the issue you mentioned when streaming video, this tool used the local file path to guess media type. Replacing it by using information from mpv should fix this (and get better media type guess results), I opened another issue (#4) for tracking this problem.

@datasone datasone closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants