Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with mpv-discord due to ipc socket #11

Closed
sitiom opened this issue Jan 21, 2023 · 4 comments
Closed

Conflicts with mpv-discord due to ipc socket #11

sitiom opened this issue Jan 21, 2023 · 4 comments

Comments

@sitiom
Copy link
Contributor

sitiom commented Jan 21, 2023

Currently, this plugin works inconsistently with mpv-discord due to the two plugins overriding the socket name.

mpv-discord names the socket to mpv-discord-{pid} while this plugin names it to mpvsocket_{pid}, perhaps there should be configurable option to change this format. Instead of sending the pid to the program, send the socket name instead and let notify_media.lua format it first with the pid in. That way, I can ideally set something like socket_path=mpvsocket_{pid} in the conf file.

@sitiom
Copy link
Contributor Author

sitiom commented Jan 22, 2023

I have created a PR in mpv-discord (tnychn/mpv-discord#46). Setting socket_path=mpvsocket_{pid} to match the naming here should now work, but ideally the plugin here should have the same configurable option.

@datasone
Copy link
Owner

Thanks for your advice on configurable socket name :D

@sitiom
Copy link
Contributor Author

sitiom commented Jan 22, 2023

Please update the readme with the new socket parameter as well

@datasone
Copy link
Owner

Yes, thanks for reminding!

@datasone datasone reopened this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants