Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header default input/output through quality param #76

Merged
merged 2 commits into from
Dec 2, 2020
Merged

header default input/output through quality param #76

merged 2 commits into from
Dec 2, 2020

Conversation

jam01
Copy link
Contributor

@jam01 jam01 commented Dec 1, 2020 •
edited by fugu13
Loading

removes the explicit default input and output header lines to instead
rely on quality media type params

Resolves #64

@jam01
header default input/output through quality param
1e71543 
removes the explicit default input and output header lines to instead
rely on quality media type params
fugu13
fugu13 requested changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@fugu13 fugu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small pieces of cleanup left, but this looks good!

src/main/java/com/datasonnet/header/Header.java Outdated Show resolved Hide resolved
src/main/java/com/datasonnet/header/Header.java Show resolved Hide resolved
src/test/java/com/datasonnet/HeaderTest.java Outdated Show resolved Hide resolved
src/test/java/com/datasonnet/HeaderTest.java Show resolved Hide resolved
@jam01 jam01 merged commit fd1273f into main Dec 2, 2020
@jam01 jam01 deleted the qparam branch December 2, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fugu13 fugu13 fugu13 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change over to quality to determine picked "default" content types
2 participants
@jam01 @fugu13