Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate QueryLog#getType, getQuery and getConsistency #47

Closed
tolbertam opened this issue Jan 5, 2018 · 1 comment
Closed

Undeprecate QueryLog#getType, getQuery and getConsistency #47

tolbertam opened this issue Jan 5, 2018 · 1 comment
Milestone

Comments

@tolbertam
Copy link
Contributor

I deprecated these field as I intended to remove them with #36, but they are actually nice to have as you don't have to inspect the frame itself. We should change these methods to extract the data from the Frame in the same way they are done today (just don't store them as separate fields).

@tolbertam tolbertam added this to the 0.8.3 milestone Jan 5, 2018
@tolbertam
Copy link
Contributor Author

In the case of EXECUTE, we need to get Query from the prime, so we should always include Query. Type and Consistency however can be extracted from the Frame.

@tolbertam tolbertam modified the milestones: 0.8.3, 0.9.0 Apr 27, 2018
@adutra adutra modified the milestones: 0.9.0, 0.11.0 Jul 13, 2020
@adutra adutra closed this as completed in 9c0ba30 Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants