Add several parser test cases #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
reviewed
Feb 27, 2019
|
@jbrockmendel Great tests, thanks for this. I have the one comment that you can take or not take about the parametrized fixture, and this also needs a changelog. I'm about to merge #890 so you may want to rebase if you're making the changes after that. |
jbrockmendel
force-pushed
the
more_cases
branch
from
5e0e16d to
800463c
Compare
|
Rebased and edited with requested changes. |
pganssle
approved these changes
Mar 1, 2019
pganssle
changed the title
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.