Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: stats cache json file not processed properly for small datasets #2476

Closed
jqnatividad opened this issue Jan 26, 2025 · 0 comments · Fixed by #2477
Closed

BUG: stats cache json file not processed properly for small datasets #2476

jqnatividad opened this issue Jan 26, 2025 · 0 comments · Fixed by #2477
Assignees
Labels
bug Something isn't working

Comments

@jqnatividad
Copy link
Collaborator

stats has a default --cache-threshold of 5000 milliseconds - only creating a stats cache if it takes more than 5 seconds to compute stats for a file.

For small files or very fast computers however, this threshold was rarely reached and the current stats caching logic was bubbling up stats.json does not exist "errors" that was causing qsv to exit, though they should have been ignored.

CI did not catch this as the "false error" only showed up whenever stats tries to check the stats.json file file on the subsequent runs.

@jqnatividad jqnatividad added the bug Something isn't working label Jan 26, 2025
@jqnatividad jqnatividad self-assigned this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant