cleanup repo init #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matoszz
commented
Dec 12, 2023
matoszz
commented
- update CODEOWNERS
- add github workflow
- update license file
- add taskfile
- updated directory "config-eslint" -> "eslint-config" given all files / directory references use "eslint-config"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
springerkc
reviewed
Dec 12, 2023
| @@ -1,3 +1,29 @@ | |||
| { | |||
| "extends": ["@repo/typescript-config/base.json"] | |||
There was a problem hiding this comment.
So we don't need to add complier options here because they're stored in our shared config
| @@ -1,3 +1,3 @@ | |||
| module.exports = { | |||
| extends: ["@repo/eslint-config/next.js"], | |||
| extends: ["@repo/packages/eslint-config/next.js"], | |||
There was a problem hiding this comment.
The repo name is @repo/eslint-config see its package.json. This is actually an incorrect import
| ``` | ||
| bunx turbo link | ||
| ``` | ||
|
|
There was a problem hiding this comment.
If we remove instructions for remote caching we are loosing performance and others who clone the repo wont know how to enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.