Too many highlight groups created by bubbly #104
Comments
|
Hello! Yes, that was desired, but mainly because when I wrote that part I didn't have a better solution to support all the colors the user could select. I have been thinking about solutions, one could be to generate at start only the combinations used by the user in the configuration. Another could be to generate a highlight per component and change the highlight colors at start or on configuration change. What do you think would be the best? I am planning to work on this when I am unocuppied from college, which would be in a month or two at maximum. Feel free to open a pull request if you prefer not to wait. |
|
Actually, I don't know how it works now. In general each component should be separate from others and it should be loaded only if it is being used. If I'll have free time I try to fix it or at least to give you some ideas. |
|
Thanks! The code for the highlight is here. |
|
This also seems to drastically slow down nvim startup with larger files, on the order of seconds for files with thousands of lines |
|
I will give this higher priority. In a month or so I will be free enough to continue working on this. I have a full rework planned for better performance. |
|
I am beginning to work in the full rework, btw |
|
Hey @datwaft, thanks for the great plugin! |
|
Sounds good, thanks! |
|
As @venkatakrishnaannam said in #108, it seems that there is no noticeable performance improvement on large files. |
|
With neovim 0.6.1 I started to have errors |
It's probably related. Bubbly generates every permutation based on the colors in the configuration. Sorry that I haven't had the time to do the full rework, life has been crazy these past months. |
Hi!
I just looked in output of the
:hicommand and was surprised of huge amount of bubbly highlight groups which is about two times more than all other highlight groups. Are you sure it is desired behavior?Here is the list:
Here is the list of highlight groups
The text was updated successfully, but these errors were encountered: