Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Commands launched in 'run' mode are duplicated in history, enclosed in quotes. #1951

Closed
1 of 2 tasks
yusufaktepe opened this issue Feb 27, 2024 · 4 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Incomplete Report - Please follow the guidelines Your report is incomplete and does not follow the guidelines, you may not expect an answer

Comments

@yusufaktepe
Copy link

Rofi version (rofi -v)

1.7.5-211-geae65b2c

Configuration

'-no-config'

Theme

'-no-config'

Timing report

No response

Launch command

rofi -no-config -show run

Step to reproduce

  • Open rofi in run mode.
  • type some 'command' and run it.
  • Now if you open rofi again, you will see 'command' is duplicated in quoted form.

Expected behavior

Duplication should not happen.

Actual behavior

'command' is duplicated in quoted form, as seen in the video:
rofi-command_duplication.webm

Additional information

No response

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Feb 27, 2024

thx for reporting. This is a known issue introduced when fixing executing of executable with a space in its name. I have not yet had time to fix.

@DaveDavenport DaveDavenport added the Incomplete Report - Please follow the guidelines Your report is incomplete and does not follow the guidelines, you may not expect an answer label Feb 27, 2024
@DaveDavenport DaveDavenport self-assigned this Feb 27, 2024
@DaveDavenport
Copy link
Collaborator

Hopefully this fixes it all cases

@yusufaktepe
Copy link
Author

Yes, it seems fixed. Thank you.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incomplete Report - Please follow the guidelines Your report is incomplete and does not follow the guidelines, you may not expect an answer
Projects
None yet
Development

No branches or pull requests

2 participants