Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Set window title #969

Closed
JonnyHaystack opened this issue May 23, 2019 · 5 comments
Closed

Feature request: Set window title #969

JonnyHaystack opened this issue May 23, 2019 · 5 comments

Comments

@JonnyHaystack
Copy link

JonnyHaystack commented May 23, 2019

It would help a lot if there was a configuration parameter that allowed you to set the window name to be something other than 'rofi'. i.e. if I could set window_name = "something" in my rofi config then that would alter the WM_NAME property of the rofi window.

The reason this would be very useful is because it allows you to use different window rules or events with different rofi configurations. For example, I mostly use the drun and ssh modi, but I have a script launched by polybar that uses rofi to select my default pulseaudio output device. For the animation of the rofi window to work nicely, I need the window to be initially invisible, and then show it when the sliding up animation starts.

The only way I know how to do this is by having a compton opacity rule to make rofi invisible and then using transset to show it when it is in position. Currently the only way I can do this is by making every rofi window initially invisible, and I have to use transset each time I use rofi, which isn't really something I want to be doing every time I use it in drun mode.

If I could set a different window name for the pulseaudio instance of rofi, then I could simply have a compton rule which only applies to that window name, which would be a lot cleaner.

Version

Version 1.5.2

@DaveDavenport
Copy link
Collaborator

@sardemff7 proposes to change the window name based on the active mode.
This sounds like a nice solution. (No extra option needed)
Would this be sufficient?

@JonnyHaystack
Copy link
Author

@DaveDavenport I don't think that would be enough, because dmenu mode is used for so many different things. I use it for the pulseaudio script, but also for LastPass, NetworkManager, etc.

@sardemff7
Copy link
Collaborator

The point would be to not use the dmenu mode but a specific named script for each of these, so we wouldn’t need to add yet another option. :-)

@JonnyHaystack
Copy link
Author

JonnyHaystack commented May 23, 2019

Ah, I didn't know about rofi userscripts until now. I was just doing things the old dmenu way 😛

In that case if each userscript has a different window name then yes, that sounds great 😃

EDIT: Only thing is that some scripts seem tricky to port over to the rofi custom modi way. Also it means I lose backwards compatibility with dmenu if I'm ever on a machine that I can get dmenu on but not rofi. I'd still like to see it as an option some day but I'd settle for having fixed window names per mode for now at least.

EDIT 2: What if it was made so that in dmenu mode, the prompt is used as (maybe part of) the window title?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants