-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zooming "catches" on edges #148
Comments
It has to be this way because the image should be centered in the dimension it doesn't fill. Otherwise when you zoom out you could leave the image off center. I don't plan to change this behaviour. |
Hmm... I suppose this is a question of whether to maintain the user's initial intended center (and "catch" to readjust because of the centering) or to change to the new apparent center as the photo's width/height becomes larger than the viewport. Google Photos takes the second approach so the zoom seems unaffected by the edge and more smooth. |
Google Photos appears to "catch" when zooming out to center the photo, but readjusts to the new center while zooming in so there's no catching. |
how to make zooming with out limit. |
I've improved the behaviour in 3.6.0. |
Here's a video of what I'm talking about: https://youtu.be/to_BOMs7H2U
From my initial debugging, what appears to happen is that the predicted
vTranslate
coordinates inonTouchEvent()
are off because of the centering infitToBounds()
, causing thevCenter
coords to be off and thevTranslate
coords to be corrected infitToBounds()
to that edge. This would explain why the further off the center, the worse the "catching" is.The text was updated successfully, but these errors were encountered: