Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel.each does not pass index and list to the callback, just the value #3

Open
danielrentz opened this issue Feb 23, 2018 · 9 comments

Comments

@danielrentz
Copy link

Documentation of Parallel.each says

The callback takes three arguments: the current element being processed, the index of the current element, and the input list.

but actually only the list value is passed, as can be seen in the signature

each<T1, T2>(list: T1[], action: {(value: T1): Promise}, concurrency?: number): Promise

Parallel.each should pass all three parameters, as Array.forEach does.

@PS-davetemplin
Copy link
Collaborator

Yes, you're right, I'll get this fixed.

@davetemplin
Copy link
Owner

OK, this should be fixed now, will publish out to npm in the next day or so if no issues are found. Thanks again for your feedback!

@danielrentz
Copy link
Author

Is the fix already supposed to be available? Nothing to see in v1.2.3.

@danielrentz
Copy link
Author

dead project?

@davetemplin
Copy link
Owner

Not dead, still actively using and maintaining it.
Other than the issue above (which it looks like I totally overlooked, sorry for that) it's been pretty rock solid.
Do you have any new issues or feedback?

@danielrentz
Copy link
Author

Hi, good to hear. No I just checked my list of open issues. Thanks for responding, I am still using the lib and am happy with it :)

@davetemplin
Copy link
Owner

Awesome, thanks!

@danielrentz
Copy link
Author

Half of a year later ... again ... nothing happened. Would you be so kind to finally publish v2.0.0 on NPM?

@danielrentz
Copy link
Author

ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants