Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) Return CA Certificate path/data #41

Merged
merged 10 commits into from
Nov 21, 2019
Merged

(feature) Return CA Certificate path/data #41

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3032280
Fixes typescript runtime errors
Oct 15, 2019
9ce6762
Encryption/chmod not required for certificate, only key
Oct 15, 2019
44ca076
Add run options & branch that returns caPath/caCert Buffer
Oct 15, 2019
ecc8e18
Reverse formatting changes
Oct 15, 2019
3443dc5
separate API concerns
Js-Brecht Nov 21, 2019
b7c3857
Add support for both `getCaPath` and `getCaBuffer` API interfaces
Js-Brecht Nov 21, 2019
a8948d9
TSDoc update
Js-Brecht Nov 21, 2019
609a693
Update conditions / return type
Js-Brecht Nov 21, 2019
e87fb6d
Add additional flags to main function TSDoc
Js-Brecht Nov 21, 2019
d561a07
Merge branch 'master' into return-ca-cert
zetlen Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,20 @@ export interface Options /* extends Partial<ICaBufferOpts & ICaPathOpts> */{
ui?: UserInterface
}

interface ICaBuffer {
ca: Buffer;
}
interface ICaPath {
caPath: string;
}
interface IDomainData {
key: Buffer;
cert: Buffer;
}
type IReturnCa<O extends Options> = O['getCaBuffer'] extends true ? ICaBuffer : false;
type IReturnCaPath<O extends Options> = O['getCaPath'] extends true ? ICaPath : false;
type IReturnData<O extends Options = {}> = (IDomainData) & (IReturnCa<O>) & (IReturnCaPath<O>);

Comment on lines +34 to +47
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetlen Because of the additional flexibility of the API, I wrote these types that will cause the return value to be more explicit, depending on what flags you set when you call certificateFor().

Let me know if you think this is too much/too complicated. The alternative is to limit it to two different return types, but then you wind up with Partial properties:

type ReturnData = {
  key: Buffer,
  cert: Buffer
} | {
  ca?: Buffer,
  caPath?: string,
  key: Buffer,
  cert: Buffer
}

This probably wouldn't be an issue, ultimately. I just wanted it to be more clear what you're getting for what you give, and also get the benefits of strong types.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the self-documenting types!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the types; there are lot of ways to type this, but if it populates autosuggest correctly, then that's all that matters. Thanks for thinking about it carefully.

/**
* Request an SSL certificate for the given app name signed by the devcert root
* certificate authority. If devcert has previously generated a certificate for
Expand All @@ -43,7 +57,7 @@ export interface Options /* extends Partial<ICaBufferOpts & ICaPathOpts> */{
* are Buffers with the contents of the certificate private key and certificate
* file, respectively
*/
export async function certificateFor(domain: string, options: Options = {}) {
export async function certificateFor<O extends Options>(domain: string, options: O = {} as O): Promise<IReturnData<O>> {
debug(`Certificate requested for ${ domain }. Skipping certutil install: ${ Boolean(options.skipCertutilInstall) }. Skipping hosts file: ${ Boolean(options.skipHostsFile) }`);

if (options.ui) {
Expand Down Expand Up @@ -76,18 +90,15 @@ export async function certificateFor(domain: string, options: Options = {}) {
}

debug(`Returning domain certificate`);
if (options.returnCa) {
return {
ca: options.getCaBuffer && readFile(rootCACertPath),
caPath: options.getCaPath && rootCACertPath,
key: readFile(domainKeyPath),
cert: readFile(domainCertPath)
}
}
return {

const ret = {
key: readFile(domainKeyPath),
cert: readFile(domainCertPath)
};
} as IReturnData<O>;
if (options.getCaBuffer) (ret as ICaBuffer).ca = readFile(rootCACertPath);
if (options.getCaPath) (ret as ICaPath).caPath = rootCACertPath;

return ret;
}

export function hasCertificateFor(domain: string) {
Expand Down