Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative URLs should be generated #17

Closed
snifter opened this issue May 10, 2016 · 1 comment
Closed

Relative URLs should be generated #17

snifter opened this issue May 10, 2016 · 1 comment

Comments

@snifter
Copy link

snifter commented May 10, 2016

Version 1.0.0-beta.2 generates absolute URLs eg:
<link rel="apple-touch-icon" sizes="57x57" href="/apple-touch-icon-57x57.png">

When in ember config baseUrl is set then favicons are not displayed because browser try to load icon from wrong directory. If url will be changed to relative:
<link rel="apple-touch-icon" sizes="57x57" href="apple-touch-icon-57x57.png">
then every thing will work fine.
@snifter snifter changed the title Relative URL's should be generated Relative URLs should be generated May 10, 2016
@davewasmer
Copy link
Owner

This won't work nested routes, i.e. if you directly navigate to example.com/some/nested/path. Also, baseUrl has been deprecated (which is more a comment on how long I've left this issue unattended 😱).

Happy to address pathing issues if any still remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snifter @davewasmer