Missing hints from iframe #28

richardmcmillen · 2022-06-29T07:06:10Z

I have only just seen this now and haven't dug into how when it is happening, highlighted blue area does not have hints and it is an iframe.

david-tejada · 2022-06-29T09:44:46Z

Can you check what those elements are? Maybe it doesn't have anything to do with being in an iframe.

richardmcmillen · 2022-06-29T11:40:45Z

They are anchor tags. This is the a site I use pretty frequently and it has worked for me previously I am almost certain.

<a class="awsui_link_4c84z_1bip0_93 awsui_variant-secondary_4c84z_1bip0_138 awsui_font-size-body-m_4c84z_1bip0_406"
  aria-label="Instances (running)" href="#Instances:instanceState=running">
  <div class="Panel">Instances (running)<span
      class="awsui_root_18wu0_1bzxa_93 awsui_box_18wu0_1bzxa_205 awsui_f-right_18wu0_1bzxa_995 awsui_color-inherit_18wu0_1bzxa_335 awsui_font-size-default_18wu0_1bzxa_221 awsui_font-weight-default_18wu0_1bzxa_261">78</span>
  </div>
</a>

david-tejada · 2022-06-29T14:14:45Z

That should work. I'll see if I can make an account and figure out what's happening

richardmcmillen · 2022-06-30T12:45:13Z

I wouldn't recommend creating an account if you can avoid it. You'll have to give over your credit card info. I'll dig a little bit and see if I can figure it out I just wanted to report in case it was something you knew about already or was obvious.

…

On Thu, 30 Jun 2022, 2:14 am David Tejada, ***@***.***> wrote: That should work. I'll see if I can make an account and figure out what's happening — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACIYKXWLKTEACQOOU3TBXTVRRK6BANCNFSM52ET37KA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

david-tejada · 2022-06-30T12:49:20Z

Yeah, I was hoping creating an account would be an easy process. If you find the time we can pair and try to fix it

david-tejada · 2022-07-01T06:30:18Z

I don't think it's this but maybe you inadvertently disable hints for the host/page. Try the command hints reset everywhere to make sure is not that.

richardmcmillen · 2022-07-02T07:05:37Z

I did hints reset everywhere and yea it didn't change anything.

So I did a bit of digging and found some things...

I noticed that the bottom of the webpage there is yet another iframe (nested in the other one) which does have hints in it - the "Help topics" section.

Debugging on Main

So I thought I would have a go at debugging myself so spun up the latest version of main and the same webpage has even less hints. I use:

npm run-script watch
web-ext run --source-dir dist-mv2

To load the extensions in to a separate instance of Firefox And I only get the hints at the very bottom of the page:

Here are some observations:

Errors in the console - DOMException: Document.querySelector: '.0-1656744554848-3410' is not a valid selector content.ts:53:10. This error seems legit due to weird identifier having a number first but I wonder if it is breaking further processing.

Yet I can't find anything element in the DOM with a class of 0-1656744554848-3410, though there is a input with this as its id

<input id="0-1656744554848-3410" aria-labelledby="0-1656744554848-3410-label" class="_input_4yi2u_db2mu_14" type="checkbox">

There is a second error in the console for the same type of issue but from a different code path:

Scroll event isn't firing - when I scroll the main part of the page (which is actually an iframe) the scroll event doesn't fire, I saw this by putting a debugger in the scroll callback function to see if it would fire and it doesn't.

richardmcmillen · 2022-07-02T07:17:30Z

Hmm I realise that possibly my debugger didn't fire because I had added a breakpoint to only one iframes content script, I am not sure how debuggers works and multiple iframes which run the same extension

I see once instance of rango for each iframe on the page of which there are about 6.

david-tejada · 2022-07-02T17:29:17Z

Sorry about this. I introduced bug when I created the code to filter out disabled elements' labels. I also mixed up the class with the id selector. That is fixed now, you can pull and try again.

I think the links in Resources not appearing could be a similar error that we are not catching and halts everything

richardmcmillen · 2022-07-03T00:58:14Z

No worries!! Thanks for taking a a look. Using the latest from main does fix the left hand sidebar hints 🎉 but the main page iframe remains un-hinted except for the nested iframe "Help Topics".

richardmcmillen · 2022-07-03T01:09:31Z

So I can only see two #rango-hints-container's in the DOM, one for the main document, and then one for the nested iframe in iframe "Help Topics" section.

richardmcmillen · 2022-07-03T02:42:06Z

Adding this only prints 2 document elements (the two that are marked up with hints), even though there are 4 iframes on the page (more if you count nested ones.)

I would have expected this to print the document from each iframe on the page regardless of whether or not the iframe is visible or not. This has kinda left me unsure where to go from here, as I was hoping to step through the logic from the page loading, but if my understanding is correct rango isn't firing for some of these iframes.

diff --git a/src/content/intersectors.ts b/src/content/intersectors.ts
index cf76a96..ab61845 100644
--- a/src/content/intersectors.ts
+++ b/src/content/intersectors.ts
@@ -2,6 +2,7 @@ import { Intersector } from "../typing/types";
 import { getClickableType } from "./utils/clickable-type";
 import { NoHintError } from "./classes/errors";
 
+console.debug(document)
 export const intersectors: Intersector[] = [];
 export const removedIntersectorsHints: Set<string> = new Set();

richardmcmillen · 2022-07-03T03:26:41Z

I checked out a previous version of rango just to make sure I wasn't misremembering and that this ever worked and with version v0.1.9 this page does seem to work, all the links you would expect are hinted:

richardmcmillen · 2022-07-03T05:38:44Z

I did a git bisect to step through commits from version v0.1.9 to v0.2.0 and it pointed to this commit which was the first commit that resulted in the main page area didn't have the hints - 2efd458

Which is weird as I can't see anything that stands out in that commit. But before this commit, it worked, with this commit applied it does not.

There are no errors in the console.

david-tejada · 2022-07-04T08:16:45Z

I ended up making an account and found out where the bug is. It's in this function:

rango/src/content/utils/background-color.ts

Lines 23 to 30 in 0c746f3

    
           export function getDefaultBackgroundColor(): Color { 
        
           	// Have to add to the document in order to use getComputedStyle 
        
           	const div = document.createElement("div"); 
        
           	document.head.append(div); 
        
           	const backgroundColor = window.getComputedStyle(div).backgroundColor; 
        
           	div.remove(); 
        
           	return new Color(backgroundColor); 
        
           }

The funny thing is that if I visit the dashboard directly the hints work but if I reload they don't. So I guess it has to do with the document not being ready when it tries to attach the element to head. Anyway, I think I'm going to scratch that code. I found it in stack overflow but I think we can assume the default color to be rgba(0, 0, 0, 0).

Thanks for your help. It would have taken me longer without it. I didn't know about git bisect, that seems really useful

david-tejada · 2022-07-04T08:57:55Z

I got to the bottom of this. Sometimes backgroundColor in line 27 is an empty string. And when you pass an empty string to new Color it results in an error. You have to wrap the statement in a try catch block to see it

richardmcmillen · 2022-07-05T01:16:41Z

Amazing David!! Thanks a lot. That is super weird, I would have expected an error to bubble up and show on the console, was there some error handling elsewhere stopping that? Git bisect is super cool! It kinda feels like a super power when I get to use it. It worked really well in this case cause the project would just auto compile and reload in the Firefox instance, super easy and quick to find the offending commit. Thanks for fixing this, I'm sorry you had to create an account with AWS. If I were you I would close the account now if you don't intend to use it. I'd hate to hear of your account being compromised and racking up a big bill.

…

On Mon, 4 Jul 2022, 10:15 pm David Tejada, ***@***.***> wrote: Closed #28 <#28> as completed. — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACIYKX3RLYTE6TJMB52ZZTVSK2STANCNFSM52ET37KA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

david-tejada · 2022-07-05T07:30:58Z

No problem, Amazon already had my card number so 🤷‍♂️. I'll close it if I see I'm not going to use it

Yeah, I don't know why the error didn't show up in the console. There is no error handling for that code, it's called from here:

rango/src/content/hints/styles.ts

Line 13 in 48226ae

const defaultBackgroundColor = getDefaultBackgroundColor();

david-tejada · 2022-11-15T15:40:24Z

So, I figured out why the exception wasn't appearing in the console. I was testing some code and I noticed there wasn't any error log for an exception that I knew was happening. The debugger would even stop if I marked "Pause on exceptions". Turns out exceptions from content scripts don't log to the Web Console in Firefox. You have to use the Browser Console if you want to see those. They log fine to the web console in Chrome, though.

1410932 - Errors raised in the content scripts context should be logged in the related tab's webconsole

richardmcmillen mentioned this issue Jul 3, 2022

Hints look a little jittery/twitchy since 0.2.0 #49

Closed

david-tejada added the v0.2.1 label Jul 4, 2022

david-tejada closed this as completed Jul 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing hints from iframe #28

Missing hints from iframe #28

richardmcmillen commented Jun 29, 2022 •

edited

Loading

david-tejada commented Jun 29, 2022

richardmcmillen commented Jun 29, 2022 •

edited

Loading

david-tejada commented Jun 29, 2022

richardmcmillen commented Jun 30, 2022 via email

david-tejada commented Jun 30, 2022

david-tejada commented Jul 1, 2022

richardmcmillen commented Jul 2, 2022 •

edited

Loading

richardmcmillen commented Jul 2, 2022

david-tejada commented Jul 2, 2022

richardmcmillen commented Jul 3, 2022 •

edited

Loading

richardmcmillen commented Jul 3, 2022

richardmcmillen commented Jul 3, 2022 •

edited

Loading

richardmcmillen commented Jul 3, 2022

richardmcmillen commented Jul 3, 2022 •

edited

Loading

david-tejada commented Jul 4, 2022

david-tejada commented Jul 4, 2022 •

edited

Loading

richardmcmillen commented Jul 5, 2022 via email

david-tejada commented Jul 5, 2022

david-tejada commented Nov 15, 2022

Missing hints from iframe #28

Missing hints from iframe #28

Comments

richardmcmillen commented Jun 29, 2022 • edited Loading

david-tejada commented Jun 29, 2022

richardmcmillen commented Jun 29, 2022 • edited Loading

david-tejada commented Jun 29, 2022

richardmcmillen commented Jun 30, 2022 via email

david-tejada commented Jun 30, 2022

david-tejada commented Jul 1, 2022

richardmcmillen commented Jul 2, 2022 • edited Loading

Debugging on Main

richardmcmillen commented Jul 2, 2022

david-tejada commented Jul 2, 2022

richardmcmillen commented Jul 3, 2022 • edited Loading

richardmcmillen commented Jul 3, 2022

richardmcmillen commented Jul 3, 2022 • edited Loading

richardmcmillen commented Jul 3, 2022

richardmcmillen commented Jul 3, 2022 • edited Loading

david-tejada commented Jul 4, 2022

david-tejada commented Jul 4, 2022 • edited Loading

richardmcmillen commented Jul 5, 2022 via email

david-tejada commented Jul 5, 2022

david-tejada commented Nov 15, 2022

richardmcmillen commented Jun 29, 2022 •

edited

Loading

richardmcmillen commented Jun 29, 2022 •

edited

Loading

richardmcmillen commented Jul 2, 2022 •

edited

Loading

richardmcmillen commented Jul 3, 2022 •

edited

Loading

richardmcmillen commented Jul 3, 2022 •

edited

Loading

richardmcmillen commented Jul 3, 2022 •

edited

Loading

david-tejada commented Jul 4, 2022 •

edited

Loading