Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in Logistic chapter #94

Open
ilapros opened this issue Sep 1, 2020 · 2 comments
Open

Typos in Logistic chapter #94

ilapros opened this issue Sep 1, 2020 · 2 comments

Comments

@ilapros
Copy link

ilapros commented Sep 1, 2020

I am reading through the chapter and found some typos/inconsistencies - sorry for not making a pull request (and thanks for making this great book available!)

When introducing the sigmoid function you have

\text{logit}^{-1}(\xi) = \frac{e^\xi}{1 + e^{\xi}} = \frac{1}{1 + e^{-\xi}}

it should be

\text{logit}^{-1}(\xi) = \frac{e^\xi}{1 + e^{\xi}} = \frac{1}{1 + e^{-\xi}}-1

I believe.

Some lines above you have

(Note, many more machine learning focused texts will use p as the number of parameters. This is an arbitrary choice, but you should be aware of it.)

but you are also using p as the number of parameters, so I was confused by the sentence.

@daviddalpiaz
Copy link
Owner

I'm not sure I understand your suggested revision to the sigmoid function. My definition seems to match what is seen here: https://en.wikipedia.org/wiki/Sigmoid_function (Perhaps I am missing something?)

To you other point, yes that is a typo. It should say number of predictors. Fixing now.

@ilapros
Copy link
Author

ilapros commented Sep 2, 2020

Yes sorry - I hadn't notice the change in the sign of ^{x} - my "correction" would have been \frac{1}{1 + e^{\xi}}-1, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants