Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add different result through search when Movie Title is not found #5

Open
TreyTC opened this issue Oct 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@TreyTC
Copy link

TreyTC commented Oct 4, 2022

Enhancement Idea

I am New to the whole Git/GitHub experience, looking to make a contribution

please... take it easy on me

When you first load the search page you are presented with an icon:

Screenshot (7)

Which is great to show the user there is no data, as there has been no search made.

I explored on the website a bit more, then ended back on the search page.

bringing us back to the search page.
I then preceded to search for a movie I would venture to guess does not exist.
It proceeded to to show no results, as well as the same icon stating No Data.

@xDavide9 I was wondering if it would be more presentable to have a separate display in this such case?

Something along the lines of "None of our records matched your search" -- or something like this?

Am Willing To Collaborate and Contribute
I Need to brush up on how to implement this into your project, but I'm up for the task.

@TreyTC
Copy link
Author

TreyTC commented Oct 4, 2022

If you feel like your project could benefit from something along these lines, then I would be glad to implement

@TreyTC TreyTC closed this as completed Oct 4, 2022
@TreyTC
Copy link
Author

TreyTC commented Oct 4, 2022

Accident.... As I said....
im new to this

@TreyTC TreyTC reopened this Oct 4, 2022
@TreyTC TreyTC changed the title enhancement: add different result through search when Movie Title is not found label:enhancement . add different result through search when Movie Title is not found Oct 4, 2022
@TreyTC TreyTC changed the title label:enhancement . add different result through search when Movie Title is not found enhancement: add different result through search when Movie Title is not found Oct 4, 2022
@davide-bianco
Copy link
Owner

davide-bianco commented Oct 4, 2022

Hello, thank you for reaching out! I think what you said is a great addition so if you wanna work on it feel free to pull request. Just be sure you pull request to branch "master" and NOT "prod". That is because the prod branch is set up for continous integration meaning pushing to it would trigger a new deploy on netlify (which we don't want unless we are sure the code is working perfectly)

@davide-bianco davide-bianco added the enhancement New feature or request label Oct 4, 2022
@davide-bianco
Copy link
Owner

davide-bianco commented Oct 4, 2022

Accident.... As I said.... im new to this

Do not worry! We are both here to learn something new, feel free to experiment with anything in the repo BUT sending pull requests to "prod" branch as I said

@davide-bianco
Copy link
Owner

If you need any further assistance by me also feel free to use this chat or contact me on discord 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants