-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapper should be optional #14
Comments
Regarding the dimensions, I wrote this mini jQuery function that calculates the natural dimensions of the image:
Using jQuery but would be really simple to remove it. |
Regarding the wrapper issue, I had to wrap it at two levels:
|
Also the zoomed image looked blury because the Changed:
I think this lib needs a good refreshing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
Great plugin, exactly what I am looking for. 😄
I am slightly disappointed though, because I expected to simply have to write:
in my articles and it would work, but it doesn't.
I happen to write my articles in markdown, so I don't have control on the HTML wrapping logic. Also
data-width
anddata-height
are great, but by default, those could value the currentwidth
andheight
of the image.Finally the content of
style.css
is unclear: is it code for your example or is it library code? The distinction should be clear. And eventually you might want to consider moving the CSS code to a JS file, so that the plugin becomes much more agnostic, with single file dependency.Thanks for taking those feedback in consideration
The text was updated successfully, but these errors were encountered: