You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
V8 7.0 changed the way Array#sort works (so the problem is only in Node.js < 11 and Chrome <70)
In V8 6.x and earlier, something funny is going on when I try to sort using a comparison function. I suspect because with each change to the array, I'm updating state.nextStore, and whatever's happening internally to do the sort is losing a reference.
V8 7.0 changed the way Array#sort works (so the problem is only in Node.js < 11 and Chrome <70)
In V8 6.x and earlier, something funny is going on when I try to sort using a comparison function. I suspect because with each change to the array, I'm updating
state.nextStore
, and whatever's happening internally to do the sort is losing a reference.The pre-7.0 behaviour is explained a bit here: https://v8.dev/blog/array-sort#history
The fix will probably be to bypass all proxies for sort, let the engine do the sort (e.g. on a clone array), then update
nextStore
with the results.The text was updated successfully, but these errors were encountered: