Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Waistline import ingredients and traces from OFF? #412

Closed
EmilJunker opened this issue Nov 28, 2021 · 3 comments · Fixed by #413
Closed

Why does Waistline import ingredients and traces from OFF? #412

EmilJunker opened this issue Nov 28, 2021 · 3 comments · Fixed by #413

Comments

@EmilJunker
Copy link
Contributor

For a while now, when importing food items from OFF, Waistline also imports the ingredients_text and traces fields. I would be interested to know why it does that. As far as I can tell, this information isn't used for anything. But especially the ingredients_text can take up a lot of valuable storage space in the local database.

If this is about food intolerances, I think it would make more sense to import just the allergens field instead of the whole ingredients_text.

Otherwise, maybe we can drop these fields altogether?

@davidhealey
Copy link
Owner

davidhealey commented Nov 28, 2021

Otherwise, maybe we can drop these fields altogether?

Yep let's drop them. I think I added support for importing them when I added support for uploading them, but can't really see a use for it. I don't think we need allergens either.

Might also be good to remove the uploading of ingredients and traces too since I think the app should keep its focus on calorie/nutrition tracking.

@teolemon
Copy link

teolemon commented Jan 7, 2023

@davidhealey Allowing Waistline users to at least take a photo of the ingredients would be hugely beneficial to the project. Wording it like "Help Waistline's datasource by sending a photo of the ingredients" could set expectations right.

@davidhealey
Copy link
Owner

Maybe we could have an additional images section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants