Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING and PORT REBUILDING for SDL2 NEEDED!] SDL2 support - Migrate (merge/migration plan for contributions by matteobin) #140

Closed
davidjoffe opened this issue Nov 7, 2022 · 2 comments

Comments

@davidjoffe
Copy link
Owner

davidjoffe commented Nov 7, 2022

EDIT THE SDL2 SUPPORT FROM MATTEO BINI HAS BEEN MERGED and I have committed a bunch of related fixes and changes and other improvements recently (e.g. safer sprintf alternatives)

The SDL2 version now needs mainly:
(1) MORE TESTING and on more platforms, and
(2) If port maintainers can please try update their ports to use SDL2 instead of SDL1!
The details of how to do that may be slightly different depending on platform but roughly speaking instead of 'libsdl1.2' and 'libsdl1.2-mixer' we now need 'libsdl2' and 'libsdl2-mixer' as dependencies.
(The dave gnukem 'readme' has these exact names needed for at least macports, and e.g. Debian .. for HaikuOS I'm a little unclear what's needed.)

ALSO PLEASE DO A GIT PULL OF LATEST https://github.com/davidjoffe/gnukem_data to update your "data" subfolders (added Matteo Bini to credits screen as he did a.o. things the SDL2 support.)

ALSO you might have to do a clean 'git clone' of your working trees if I rewrite history for: #153

Question Is the OpenPandora port still actively maintained and if so who is maintaining it?

(In future I may want to add more dependencies, e.g. possibly sdlimage for e.g. .png support, and maybe e.g. ttf libraries or something else for Unicode rendering in future, but for now just the above, but keep in mind)

I am wondering should the Makefile become slightly more like it 'tries to detect if "sdl2-config" is present and ideally just runs that by default if present to get the local settings? and a bit less hardcoded-y (but perhaps some ports need/want hardcodedness - please give me feedback on the Makefile settings for your port and I can try integrate into the main Makefile if possible or else I can add more Makefiles with custom extensions e.g. "Makefile.platform" - either do push request or if you want repo access please ask me and let me know what you'd like to do with repo access)

The 1.0.2 release is the 'last official' repo head of the SDL1-based version (in case any port maintainers want/need for some to stick to SDL1 in future) but SDL2 is the way forward in future if/as far as possible.

See pull request by @matteobin (thank you so much for this!) and my comments here:
#135

@matteobin

@davidjoffe davidjoffe changed the title SDL2 support? SDL2 support? Migrate (merge/migration plan for contributions by matteobin)? Nov 7, 2022
@davidjoffe
Copy link
Owner Author

This is 'coming soon'!

@davidjoffe davidjoffe self-assigned this Nov 19, 2022
@davidjoffe
Copy link
Owner Author

davidjoffe commented Nov 19, 2022

This is now 'done but could use more testing!'

Thanks again to Matteo Bini who just contributed this entirely on his own initiative.

@davidjoffe davidjoffe changed the title SDL2 support? Migrate (merge/migration plan for contributions by matteobin)? SDL2 support - Migrate (merge/migration plan for contributions by matteobin) Nov 20, 2022
@davidjoffe davidjoffe pinned this issue Nov 20, 2022
@davidjoffe davidjoffe changed the title SDL2 support - Migrate (merge/migration plan for contributions by matteobin) [TESTING AND PORT REBUILDING NEEDED!] SDL2 support - Migrate (merge/migration plan for contributions by matteobin) Nov 20, 2022
@davidjoffe davidjoffe changed the title [TESTING AND PORT REBUILDING NEEDED!] SDL2 support - Migrate (merge/migration plan for contributions by matteobin) [TESTING and PORT REBUILDING for SDL2 NEEDED!] SDL2 support - Migrate (merge/migration plan for contributions by matteobin) Nov 20, 2022
@davidjoffe davidjoffe added this to the 1.0.4 milestone Nov 20, 2022
@davidjoffe davidjoffe unpinned this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant