Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: ReferenceError: process is not defined #1756

Merged
merged 5 commits into from
Dec 20, 2020

Conversation

dimitardanailov
Copy link
Contributor

package: @xstate/react
Parent pull request: #1738

Issue:
If someone import: https://unpkg.com/@xstate/react@1.2.0/dist/xstate-react.umd.min.js. The import throws the following error: ReferenceError: process is not defined

The current patch uses rollup-replace to remove the unnecessary variable: process.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2020

🦋 Changeset detected

Latest commit: adcbe18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@xstate/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist
Copy link
Member

@dimitardanailov thanks for the PR! Please note that I've force-pushed to your branch so it would be best if you just reset to our current master

@github-actions github-actions bot mentioned this pull request Dec 20, 2020
@dimitardanailov
Copy link
Contributor Author

dimitardanailov commented Dec 26, 2020

@Andarist

I wish you a happy holiday period. I'd like to share with you a new issue: The issue is:

xstate-react.umd.min.js:16 Uncaught TypeError: n is not a function

Screen Shot 2020-12-26 at 9 46 28 PM

  1. What's your opinion if library supports Unminified version ? My personal opinion is: The full version or source map version will be useful if umd.min.js has an issue.

  2. I've been working to understand why the issue occurs.

Update
I forgot to share how the library is used: const { useMachine } = XStateReact. The previous declaration was: import { useMachine } from '@xstate/react'

@dimitardanailov
Copy link
Contributor Author

I'd like to share my personal thoughts:

The error behind error is a missing dependency. The missing dependency is: use-isomorphic-layout-effect(https://github.com/Andarist/use-isomorphic-layout-effect). I can't find a suitable browser version.

@Andarist
Copy link
Member

What's your opinion if library supports Unminified version ? My personal opinion is: The full version or source map version will be useful if umd.min.js has an issue.

source maps could be generated for .min.js files

The error behind error is a missing dependency. The missing dependency is: use-isomorphic-layout-effect(https://github.com/Andarist/use-isomorphic-layout-effect). I can't find a suitable browser version.

From what I've checked the culprit is not the use-isomorphic-layout-effect but the use-subscription. I've fixed the problem locally but it's late already and gonna push out the fix tomorrow.

dsngo added a commit to dsngo/xstate that referenced this pull request Feb 24, 2021
* Created xstate-svelte directory and added support for @xstate/fsm.

* Added support for xstate and tests.

* Updated svelte-jester to allow running tests from project root.

* Add createModel + test

* Update test to show full typing

* Rename withUpdaters -> withAssigners, fix mapValue types

* Fix typings for createModel

* Improve types

* Do not crash when stopping already stopped interpreter. Fixes statelyai#1697

* Add changeset

* WIP: model updates

* Simplify model

* Add comment

* Update resources.md

* Fixed an issue with `process` references not being removed correctly from the `@xstate/react` UMD bundles (statelyai#1756)

* 'rollup-replace' replaces process.env.NODE_ENV declarations.

* rollup-replace is a dependency.

* 'rollup-replace' replaces process.env.NODE_ENV declarations.

* Use the same version of rollup-plugin-replace across the repo

* tweak changeset

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Version Packages (statelyai#1760)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Rename context -> initialContext, use ExtractEvent

* Remove actions property

* Fix types

* Update description in svelte.md

Add import statement: import replace from "@rollup/plugin-replace"; to documentation

* Refactoring!

* WIP

* Fixed an issue with events received from callback actors not having the appropriate `_event.origin` set

* Version Packages

* Finish refactoring

* Export createDevTools

* Update packages/xstate-inspect/src/utils.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Update packages/xstate-inspect/examples/server.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Add global shim

* Fix rollup config

* Add null check

* Add changeset and update README.md

* Fixed an issue with some external packages not being bundled correctly into the `@xstate/react` UMD bundles (statelyai#1780)

* Version Packages (statelyai#1781)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Switch to Vue 3 compatibility that has builtin support for the composition API (statelyai#1629)

* build: set Vue 3 as dev and peer dependencies

* refactor: import dependencies from Vue package

* refactor: import test dependencies from Vue package

* refactor: replace Composition API global with Vue

* build: remove Composition API package

* docs: add changeset

* fix: apply suggestion from code review

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Fix tests etc.

* Re-enable husky git hooks

* Remove unnecessary dep & config stuff

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: David Khourshid <davidkpiano@gmail.com>

* Version Packages

* Update README.md

Add Vue 3 template

* Version Packages

* Update docs

* Fixed a typo parenthesis in the docs (statelyai#1798)

* Ensure that services are registered by inspect client. Fixes statelyai#1797

* Add changeset

* Version Packages

* Update yarn.lock

* Update README.md

* `machine.resolveState(state)` calls should resolve to the correct value of `.done` property now (statelyai#1816)

* Version Packages

* Update resources.md

* Update resources.md

* Create deno.md (statelyai#1830)

* Create deno.md

Just wanted to mention how to get XState working on Deno.  Not sure if 'recipes' is the best place, but not sure of anywhere better?

* Update docs/recipes/deno.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Update resources.md

* Update resources.md

* Update resources.md

* Remove RestrictedActions

* Add model.reset()

* Revert changed types

* Fix TransitionsConfigMap

* Fix types in tests

* Remove unused function

* Add changeset

* Revert types

* Version Packages

* Add useMachineObserver

* Add tests

* Update resources.md

* Update resources.md

* Updated dependency versions

* Improved `.matches(value)` inference for typestates containing union types as values

* Changed minimum @types/jest version to 24.0.23

* Fix a bound TTypestate not being able to satisfy the default value

* Copied yarn.lock from master and then ran yarn

* Update resources.md

* Fsm actions no longer merged.

* Added 'service' to returned object

* Update resources.md

* Update .changeset/clean-walls-breathe.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Rename useMachineObserver -> useInterpret

* Move useInterpret to file

* Fixed URL to a codesandbox demoing @xstate/inspect using vanilla JS  (statelyai#1878)

It was pointing to TS template.

* Documented using useMachine. Adapted xstate-react examples.

* Added 'Services' section to svelte readme.

* Corrections to svelte readme

* Corrected link in svelte readme

* Remove duplicated import from React in xstate-viz (statelyai#1897)

* Remove React double import

* Add changeset for removing react double import

* Revert "Add changeset for removing react double import"

This reverts commit 859845f.

* Update resources.md

* Update resources.md

* Update immer

* Remove xstate-dev

* Fix TS issues

* Fixing types

* Add changeset

* Update resources.md

* Add support for "internal" transitions

* Update shy-toes-worry.md

* Add changeset

* Update resources.md

* Version Packages

* Update .changeset/afraid-eggs-wonder.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Update packages/xstate-fsm/src/index.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

* Refactor

* Version Packages

* docs: remove Spectrum.chat

& where Spectrum.chat is appropriate, remind that GH Discussions is for XState-specific questions

* Update README.md

* Update README.md

* + discussions link

* replace Gitter "chat" with Discord

* Add useSelector + tests

* Fix types

* Version Packages

* Add test

* Separate useReactEffectActions

* Don't use instanceof

* Add test for comparison function

* Update resources.md

* Add useIsomorphicLayoutEffect + consolidate options assignment

* Update README.md

* Fixed an issue with synchronous initial updates not updating useMachine

* Move implementations update to a layout effect to avoid stale closure problems for layout effects

* Update resources.md

* Update resources.md

* Fix selector subscription

* Don't update guards

* Separate observer subscription

* Update resources.md

* Adds final states to test plan description

* Adds changeset

* Version Packages

* Revert options changes

* Add changesets

* Update useSelector

* Memoize listener

* Update resources.md

* Update resources.md

* Update resources.md

* Update README.md

* Version Packages

* add typestate type to service returned from react/fsm useMachine

* Add changeset

* Fixed @xstate/react UMD build by redeclaring toObserver (statelyai#1950)

* Version Packages (statelyai#1949)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update resources.md

* docs: add new resource

Github - XState with React and Angular in Nx Workspace

* Update docs

* Update @xstate/react README.md

* Fix README.md

* Update resources.md

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: David Khourshid <davidkpiano@gmail.com>
Co-authored-by: Dimitar Danailov <dimityr.danailov@gmail.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: jonasholbech <jh@jonasholbech.dk>
Co-authored-by: Sarah Dayan <dayan.sarah@gmail.com>
Co-authored-by: decaylala <decaylala@users.noreply.github.com>
Co-authored-by: Tom Byrer <tomByrer@gmail.com>
Co-authored-by: Hosein <hosein2398@gmail.com>
Co-authored-by: Jim Wheaton <jimwheaton@gmail.com>
Co-authored-by: Luke Karrys <lukekarrys@gmail.com>
Co-authored-by: Chau Tran <nartc7789@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants