Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve local linting run script #798

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Nov 7, 2024

Improves running linting locally:

  • Use maxWarnings: 0 as in CI/CD.
    • Add it to angular.json in case of running ng lint instead of pnpm run lint
  • Add lint:code and lint:commit-message tasks to lint both code and commit messages
  • Replace lint run script by a command that runs both tasks in parallel
  • Use lint:code in CI/CD, remove it from Makefile

Inspired in https://github.com/davidlj95/ngx setup

@davidlj95 davidlj95 enabled auto-merge (squash) November 7, 2024 16:55
Copy link
Owner Author

davidlj95 commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (058c91f) to head (105ed7f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files         124      124           
  Lines         642      642           
  Branches       81       81           
=======================================
  Hits          614      614           
  Misses         20       20           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 3f516c7 into main Nov 7, 2024
15 checks passed
@davidlj95 davidlj95 deleted the stacked/build-improve-local-linting-run-script branch November 7, 2024 16:59
Copy link

🎉 This PR is included in version 2.62.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant