Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code on npm does not match the code on Github #1

Closed
just-boris opened this issue Jun 1, 2019 · 2 comments
Closed

Code on npm does not match the code on Github #1

just-boris opened this issue Jun 1, 2019 · 2 comments

Comments

@just-boris
Copy link

Hello!

NPM release contains the actual implementation of events.once, as expected: https://unpkg.com/events.once@2.0.2/index.js

But this repository code is somewhat different: https://github.com/davidmarkclements/events.on/blob/master/index.js

Perhaps you pushed a wrong branch/commit?
@davidmarkclements
Copy link
Owner

davidmarkclements commented Jun 1, 2019 •
edited
Loading

  1. this is events.on you're looking for https://github.com/davidmarkclements/events.once
  2. this isn't published yet - it's just a placeholder until events.on lands in core (events: add EventEmitter.on to async iterate over events nodejs/node#27994 (review)) where it'll be updated to correspond.

@just-boris
Copy link
Author

Correct. I have confused two repos somehow. Sorry about that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@just-boris @davidmarkclements