Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API work with an already running event loop #198

Closed
wants to merge 4 commits into from

Conversation

crazygmr101
Copy link
Contributor

@crazygmr101 crazygmr101 commented Jul 26, 2020

Related #123
Related #115 ?

Uses a separate thread to run the event loop for TikTokApi, since only one event loop can be ran at a time. This allows the Api to be used in applications that already use the event loop, i.e. Discord bots

@crazygmr101
Copy link
Contributor Author

Note, the library is still mainly sync in how it's called - a bit of a rewrite would be required to change that

@crazygmr101
Copy link
Contributor Author

Looks like this also might fix #146

@davidteather
Copy link
Owner

Travis is failing probably because the loop is never closed

@crazygmr101
Copy link
Contributor Author

Travis is failing probably because the loop is never closed

Fair point, I'm on the way to work but I can fix that later tonight then

@crazygmr101
Copy link
Contributor Author

Waiting on 955e906 - 65cb4fd passed but didn't actually let me close the loop in my bot

@davidteather
Copy link
Owner

I resolved conflicts in #232 sorry it took me so long to test.

davidteather added a commit that referenced this pull request Aug 24, 2020
Make API work with an already running event loop #198
@crazygmr101 crazygmr101 deleted the patch-1 branch September 24, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants