-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API work with an already running event loop #198
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, the library is still mainly sync in how it's called - a bit of a rewrite would be required to change that |
Looks like this also might fix #146 |
Travis is failing probably because the loop is never closed |
Fair point, I'm on the way to work but I can fix that later tonight then |
This was referenced Jul 30, 2020
I resolved conflicts in #232 sorry it took me so long to test. |
davidteather
added a commit
that referenced
this pull request
Aug 24, 2020
Make API work with an already running event loop #198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #123
Related #115 ?
Uses a separate thread to run the event loop for TikTokApi, since only one event loop can be ran at a time. This allows the Api to be used in applications that already use the event loop, i.e. Discord bots