Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API work with an already running event loop #198 #232

Merged
merged 6 commits into from
Aug 24, 2020

Conversation

davidteather
Copy link
Owner

This is #198 but with conflicts resolved

@davidteather davidteather changed the base branch from master to nightly August 24, 2020 19:46
@davidteather davidteather merged commit 4004940 into nightly Aug 24, 2020
@davidteather davidteather deleted the crazygmr101-patch-1 branch August 24, 2020 19:47
@crazygmr101
Copy link
Contributor

No worries. I could continue work on a fully async fork, if you'd like, and save trouble here :)

@davidteather
Copy link
Owner Author

That would be much appreciated, thanks!

@davidteather
Copy link
Owner Author

@crazygmr101 I'm not sure why, but when I resolved issue between our branches the package has been throwing some weird errors. It doesn't break the application as it only seems to be an issue when the TikTokApi instance is used for the last time it throws

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/opt/python/3.5.6/lib/python3.5/asyncio/base_events.py", line 454, in run_until_complete
    self.run_forever()
  File "/opt/python/3.5.6/lib/python3.5/asyncio/base_events.py", line 408, in run_forever
    raise RuntimeError('This event loop is already running')

It seems to throw 4 of these errors for each time the TikTokApi class is destroyed

@crazygmr101
Copy link
Contributor

Might be something I missed, I'll check it out tonight

@davidteather
Copy link
Owner Author

Thanks! Not sure if it was your branch's issue, because I did test it. I think I would've noticed if it threw an error. I'll keep looking

@crazygmr101
Copy link
Contributor

crazygmr101 commented Aug 24, 2020

Alrighty. If ya need to contact me, discord is fastest, crazygmr101#5324. (better than a github issue :p)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants